Hey @cygaar thanks for the help in fixing this very annoying integration test! Retrying until the search index has been created is indeed the right way of fixing this. However, create_search_index doesn't actually return an error if the search index is not ready (so your loop will always exit on the first iteration).

Instead, I think the way to do this is to poll the list_search_indices function until the search index has status == READY. Something like:

// in `create_search_index` after creating the index
while attempts < max_attempts {
    match collection
        .list_search_indexes()
        .name(index_name)
        .await?
        .with_type::<rig_mongodb::SearchIndex>()
        .next()
     {
         Some(index) if index.status == "READY" => return,
         Some(_) => continue
         None => panic!() 
     }
}

I'll fix shortly!

@cvauclair I'm pretty sure the logic I have here works - I added a log to check if the index was created and it seems to work.
I checked the definition of create_search_index and it does return a value.

@cygaar apologies I wasn't very clear. The value returned by Collection::create_search_index is a builder struct, but the request is only executed when you call .await on the builder, and the return value is a Result<String, mongodb::Error> which will only be Err if the command was not successful, but Ok does not mean that the index is necessarily ready.

The docs suggest using list_search_indexes to check the status of an index (see the "important" section here).

ah cool, i'll look into that

FYI I had increased the delay further to 30s in another PR that has since been merged (hence the merge conflict), but feel free to reduce it back to 5s (or remove it entirely) once the polling for READY status is done!

I will note that the creation of the search index is what's causing the original error - we would essentially need to keep the logic i currently have and add an additional check to make sure the index was created

@cvauclair i think the last test failure is related to missing api keys - not entirely sure how you guys have github actions setup to get that to work